Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namespace Vector6d to dynamic_graph::sot #57

Open
NoelieRamuzat opened this issue Feb 27, 2019 · 0 comments
Open

Change namespace Vector6d to dynamic_graph::sot #57

NoelieRamuzat opened this issue Feb 27, 2019 · 0 comments

Comments

@NoelieRamuzat
Copy link
Contributor

Dear all,

Current pb: we have moved a part of vector-conversions.hh to matrix-geometry.hh to share the tools.
The problem is that matrix-geometry.hh use to have Vector6d in the namespace dynamic_graph::sot.
The trick in vector-conversions.hh of using the namespace of Eigen might be misleading (actually it was for Olivier) in letting think the reader that this is an Eigen type.
If this is ok with you I would advocate to use the namespace dynamic_graph::sot with a short cut (dyn::sot) for Vector6d, and propose a PR on sot-torque-control ?

Thank you
Olivier and Noëlie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant