[signal, include, tools] Use robot_utils' sot-core files instead of the ones of sot-torque-control #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 28, 2019 10:12
common and signal-helper are now in sot-core and logger is defined for each entity Common is called robot_utils in sot-core.
Added robot-utils-py.cpp in sot-core from common-py.cpp of sot-torque-control Complete the moving of "common" to "robot_utils" by moving the python wrapper Changing the CMakeLists accordingly.
Use robot_utils, signal_helper and matrix_geometry from sot-core instead of common and signal_helper or with vector_conversion from sot-torque-control. Remove logger includes and use directly sendMsg method of robot_utils instead of getLogger.sendMsg.
Move a part of vector-conversions.hh to matrix-geometry.hh in sot-core to share the tools Use the namespace dynamic_graph::sot with a short cut (dg::sot) for VectorXd instead of Eigen:: for consistency.
NoelieRamuzat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-request linked to the creation of
robot_utilstool in sot-core based oncommonfrom sot-torque-control.robot_utils,signal_helperandmatrix_geometryfrom sot-core instead ofcommon,signal_helperandvector_conversionfrom sot-torque-control.loggerincludes and use directlysendMsgmethod ofrobot_utilsinstead ofgetLogger.sendMsg.commontorobot_utilsby moving the python wrapper, changing the CMakeLists accordingly. (see PR #79)Use the namespace dynamic_graph::sot with a short cut (dg::sot) for Vector[1|6]d instead of Eigen. (fix the issue Change namespace Vector6d to dynamic_graph::sot #57)
WARNING: This pull-request should follow the ones about the macros:
Fix the sot-core convention to follow the one of dynamic_graph #78 and #35.