Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes to append public or private keywords #23

Merged
merged 4 commits into from
Nov 25, 2023

Conversation

limxingzhi
Copy link
Contributor

  • appended private keyword to fix own props
  • appended private keyword to fix own methods
  • appended public keyword to fix decorated props

Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The fixers for own-methods-must-be-private and own-methods-must-be-private work great! I'm a little hesitant to add a fixer to props-must-be-public, would you mind removing that one?

src/rules/props-must-be-public.ts Outdated Show resolved Hide resolved
@StevenMeyer
Copy link
Contributor

Also is adding private the fix? The ES private # is private, too.

@limxingzhi limxingzhi requested review from a team and rwaskiewicz December 1, 2021 11:16
- appended private keyword to fix own props
- appended private keyword to fix own methods
@raphaelpor
Copy link
Collaborator

Hey @rwaskiewicz,
Do you still think this change is valid? Just asking since you have started reviewing it.
If so, I can proceed with the testing/merging. :)

@rwaskiewicz
Copy link
Contributor

@raphaelpor Yes, I think this still looks good. Comparing the current changes to what I have on @limxingzhi's branch from when I initially reviewed, it looks like all the feedback has been addressed. I haven't done any testing, but it looks good to me from the standpoint of my initial review 👍

@raphaelpor
Copy link
Collaborator

@rwaskiewicz Great! I will take a look and merge it for the next release.

Thanks! ✌️

@raphaelpor
Copy link
Collaborator

@limxingzhi Hello and thanks for your contribution.

Sorry for taking so long to review your code. But looks like the tests are failing, now.
Get we get some help from you or someone else to fix them?

@raphaelpor raphaelpor added Help Wanted Extra attention is needed Awaiting Reply Further information is requested labels Nov 22, 2023
@limxingzhi
Copy link
Contributor Author

It has been over a year since I worked on this tech stack, I would be more than happy if someone took over

@raphaelpor raphaelpor removed the Awaiting Reply Further information is requested label Nov 24, 2023
@raphaelpor raphaelpor merged commit 425cfa2 into stencil-community:main Nov 25, 2023
6 checks passed
jcfranco referenced this pull request in Esri/calcite-design-system Apr 3, 2024
….7.2 (#9036)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@stencil-community/eslint-plugin](https://togithub.com/stencil-community/stencil-eslint)
| [`0.7.1` ->
`0.7.2`](https://renovatebot.com/diffs/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil-community%2feslint-plugin/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil-community%2feslint-plugin/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>stencil-community/stencil-eslint
(@&#8203;stencil-community/eslint-plugin)</summary>

###
[`v0.7.2`](https://togithub.com/stencil-community/stencil-eslint/releases/tag/v0.7.2)

[Compare
Source](https://togithub.com/stencil-community/stencil-eslint/compare/v0.7.1...v0.7.2)

#### What's Changed

- Added fixes to append public or private keywords by
[@&#8203;limxingzhi](https://togithub.com/limxingzhi) in
[https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23)
- fix(reserved-member-names): improve reserved member check by using
`HTMLElement` by [@&#8203;jcfranco](https://togithub.com/jcfranco) in
[https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101)

#### New Contributors

- [@&#8203;limxingzhi](https://togithub.com/limxingzhi) made their first
contribution in
[https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23)
- [@&#8203;jcfranco](https://togithub.com/jcfranco) made their first
contribution in
[https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101)

**Full Changelog**:
stencil-community/stencil-eslint@v0.7.1...v0.7.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Esri/calcite-design-system).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants