-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fixes to append public or private keywords #23
Conversation
limxingzhi
commented
Mar 5, 2021
- appended private keyword to fix own props
- appended private keyword to fix own methods
- appended public keyword to fix decorated props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The fixers for own-methods-must-be-private
and own-methods-must-be-private
work great! I'm a little hesitant to add a fixer to props-must-be-public
, would you mind removing that one?
Also is adding |
- appended private keyword to fix own props - appended private keyword to fix own methods
Hey @rwaskiewicz, |
@raphaelpor Yes, I think this still looks good. Comparing the current changes to what I have on @limxingzhi's branch from when I initially reviewed, it looks like all the feedback has been addressed. I haven't done any testing, but it looks good to me from the standpoint of my initial review 👍 |
@rwaskiewicz Great! I will take a look and merge it for the next release. Thanks! ✌️ |
@limxingzhi Hello and thanks for your contribution. Sorry for taking so long to review your code. But looks like the tests are failing, now. |
It has been over a year since I worked on this tech stack, I would be more than happy if someone took over |
….7.2 (#9036) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil-community/eslint-plugin](https://togithub.com/stencil-community/stencil-eslint) | [`0.7.1` -> `0.7.2`](https://renovatebot.com/diffs/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil-community%2feslint-plugin/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil-community%2feslint-plugin/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>stencil-community/stencil-eslint (@​stencil-community/eslint-plugin)</summary> ### [`v0.7.2`](https://togithub.com/stencil-community/stencil-eslint/releases/tag/v0.7.2) [Compare Source](https://togithub.com/stencil-community/stencil-eslint/compare/v0.7.1...v0.7.2) #### What's Changed - Added fixes to append public or private keywords by [@​limxingzhi](https://togithub.com/limxingzhi) in [https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23) - fix(reserved-member-names): improve reserved member check by using `HTMLElement` by [@​jcfranco](https://togithub.com/jcfranco) in [https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101) #### New Contributors - [@​limxingzhi](https://togithub.com/limxingzhi) made their first contribution in [https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23) - [@​jcfranco](https://togithub.com/jcfranco) made their first contribution in [https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101) **Full Changelog**: stencil-community/stencil-eslint@v0.7.1...v0.7.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>