Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fixes to append public or private keywords #23

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Added fixes to append public or private keywords #23

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fda2dbf
feat: added fixes for decorated props, own props and own methods
limxingzhi Dec 1, 2021
09529f2
Merge branch 'main' into pr/23
raphaelpor Nov 22, 2023
e4716fe
Fix tests
raphaelpor Nov 25, 2023
aa65f13
Merge branch 'main' into master
raphaelpor Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/rules/own-methods-must-be-private.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const rule: Rule.RuleModule = {
recommended: true,
},
schema: [],
type: "problem",
type: 'problem',
fixable: 'code',
},

create(context): Rule.RuleListener {
Expand Down Expand Up @@ -44,6 +45,9 @@ const rule: Rule.RuleModule = {
context.report({
node: node,
message: `Own class methods cannot be public`,
fix(fixer) {
return fixer.insertTextBefore(node.key, 'private ');
}
});
}
},
Expand Down
8 changes: 6 additions & 2 deletions src/rules/own-props-must-be-private.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ const rule: Rule.RuleModule = {
recommended: true,
},
schema: [],
type: "problem",
type: 'problem',
fixable: 'code',
},

create(context: any): Rule.RuleListener {
create(context): Rule.RuleListener {
const stencil = stencilComponentContext();

const parserServices = context.parserServices;
Expand All @@ -41,6 +42,9 @@ const rule: Rule.RuleModule = {
context.report({
node: node,
message: `Own class properties cannot be public`,
fix(fixer) {
return fixer.insertTextBefore(node.key, 'private ');
}
});
}
},
Expand Down
Loading