Fix warnings emitted by emscripten compiler #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpdemarco
commented
Jul 27, 2022
| @@ -671,8 +671,7 @@ BOOST_AUTO_TEST_CASE(future_reduction_with_mutable_void_task) { | |||
| BOOST_TEST_MESSAGE("future reduction with mutable task"); | |||
|
|
|||
| std::atomic_int check{0}; | |||
| auto func = [i = int{0}, &check]() mutable { | |||
There was a problem hiding this comment.
This might be intentionally unused - but the compiler complained. I'm not sure what the purpose of it would be, though. @FelixPetriconi @sean-parent if you wrote this test and want this variable around, let me know.
Merged
camio
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Approving. Just some nitpicks on the PR's/commit message's title
- Prefer a single imperative-tense sentence that doesn't end with a period.
- Try to keep it high-level and understandable in a git log summary.
Something like "Fix warnings emitted by emscripten compiler" would be good. The specific warnings could go in the next paragraph.
nickpdemarco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: -Wunqualified-std-cast-call and -Wunused-but-set-variable.