Migrate tests/test_maamped.py to npt.assert_allclose - #1199
Merged
seanlaw merged 1 commit intoAug 25, 2026
Conversation
Contributor
Author
|
@seanlaw next one — same conventions as before. |
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1175
tests/test_maamped.py(20 sites) — the dask-parallel counterpart totest_maamp.py. Renamedcomptocmp, flipped order.maamped()returns cleanfloat64/int64(P, I) just like the CPU version, so no casting needed anywhere. One site keeps theconfig.STUMPY_TEST_PRECISIONreference.53/53 passing locally in both normal and CI-equivalent modes.
To Do List
assert_allclose,cmpfirstatol=1.5e-07/ config reference where it wascmpnotcompref_/cmp_naming, no casting neededPull Request Checklist
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory and ensured that all tests are passing locallyOnly request a review after the checklist above is fully completed!