Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modular foundational support for GCP #36

Merged
merged 21 commits into from
Sep 16, 2024
Merged

Add modular foundational support for GCP #36

merged 21 commits into from
Sep 16, 2024

Conversation

haresh-suresh
Copy link
Contributor

Add modular foundational support for GCP

This adds the following :

  1. Module implementation for Onboarding with sysdig account & org creation as needed
  2. Module implementation for Config Posture with sysdig component creation
  3. Adding examples for single & org foundational install

@haresh-suresh haresh-suresh requested a review from a team as a code owner September 5, 2024 22:26
@haresh-suresh haresh-suresh mentioned this pull request Sep 6, 2024
Merged
ravinadhruve10
ravinadhruve10 reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates and comments, rest lgtm.

modules/config-posture/README.md Outdated Show resolved Hide resolved
modules/config-posture/README.md Show resolved Hide resolved
modules/config-posture/README.md Outdated Show resolved Hide resolved
modules/config-posture/README.md Outdated Show resolved Hide resolved
modules/config-posture/README.md Outdated Show resolved Hide resolved
modules/config-posture/README.md Show resolved Hide resolved
modules/onboarding/README.md Outdated Show resolved Hide resolved
modules/onboarding/main.tf Show resolved Hide resolved
test/examples/modular_organization/onboarding_with_posture.tf Outdated Show resolved Hide resolved
test/examples/modular_single_project/onboarding_with_posture.tf Outdated Show resolved Hide resolved
ravinadhruve10
ravinadhruve10 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes! :)

@haresh-suresh haresh-suresh merged commit 15672c7 into master Sep 16, 2024
8 checks passed
@haresh-suresh haresh-suresh deleted the add-modular-foundational branch September 16, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

@cgeers cgeers Awaiting requested review from cgeers

@jose-pablo-camacho jose-pablo-camacho Awaiting requested review from jose-pablo-camacho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haresh-suresh @ravinadhruve10