Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(updater): migrate run updater using powershell to ShellExecute #1054

Merged

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Mar 8, 2024

Fix flashing powershell window on update

@Legend-Master Legend-Master force-pushed the migrate-updater-to-shell-execute branch from 2bac69a to f7784d0 Compare March 12, 2024 00:55
@Legend-Master Legend-Master marked this pull request as ready for review March 12, 2024 00:55
@Legend-Master Legend-Master requested a review from a team as a code owner March 12, 2024 00:55
@Legend-Master
Copy link
Contributor Author

Note: I have not tested this yet

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left a few comments for now and will test later

plugins/updater/Cargo.toml Outdated Show resolved Hide resolved
plugins/updater/Cargo.toml Outdated Show resolved Hide resolved
plugins/updater/Cargo.toml Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
@Legend-Master
Copy link
Contributor Author

I doubt I did it right on the windows-sys version, felt like I was just cheating on the compiler 🤣

plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit a3b5396 into tauri-apps:v2 Mar 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants