Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express bun added #7882

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Express bun added #7882

merged 2 commits into from
Oct 23, 2024

Conversation

zahidcakici
Copy link
Contributor

express-bun added to the project as cluster.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you homogenize all cluster.ts, I mean for all bun based ?

I am not working with js/ts, I let you decide the most production-ready solution

Copy link
Contributor Author

@zahidcakici zahidcakici Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because express is a npm package and we can't use the bun's build in cluster structure unlike other native bun frameworks. So I think a common structure is not possible right now. At least we can keep the same folder structure and Dockerfile.

I also stuied the clustering deno case, tried many solutions but couldn't find a proper way. As you know the deno frameworks in repository is running on single instance even if we run it with pm2 '-i max' command since the same problem with npm packages.

At least bun supports node cluster package unlike deno.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some comments to specify that. I mean the idea is to use some wiki, or other things to have documentation.

Maybe we can specify it in a README in javascript folder.

@waghanza waghanza merged commit 98ac54d into the-benchmarker:master Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants