-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express bun added #7882
Merged
Merged
Express bun added #7882
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import express from 'express'; | ||
|
||
const app = express(); | ||
app.set('etag', false); | ||
|
||
app.get('/', (req, res) => { | ||
res.send(''); | ||
}); | ||
|
||
app.get('/user/:id', (req, res) => { | ||
res.send(req.params.id); | ||
}); | ||
|
||
app.post('/user', (req, res) => { | ||
res.send(''); | ||
}); | ||
|
||
app.listen(3000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import cluster from "node:cluster"; | ||
import os from "node:os"; | ||
|
||
const cpus = os.availableParallelism(); | ||
|
||
if (cluster.isMaster) { | ||
for (let i = 0; i < cpus; i++) { | ||
cluster.fork(); | ||
} | ||
} else { | ||
await import("./app.ts"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
framework: | ||
website: expressjs.com | ||
version: 4.21 | ||
|
||
engines: | ||
- bun |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"type": "module", | ||
"dependencies": { | ||
"express": "~4.21.1" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you homogenize all cluster.ts, I mean for all bun based ?
I am not working with js/ts, I let you decide the most production-ready solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because express is a npm package and we can't use the bun's build in cluster structure unlike other native bun frameworks. So I think a common structure is not possible right now. At least we can keep the same folder structure and Dockerfile.
I also stuied the clustering deno case, tried many solutions but couldn't find a proper way. As you know the deno frameworks in repository is running on single instance even if we run it with pm2 '-i max' command since the same problem with npm packages.
At least bun supports node cluster package unlike deno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some comments to specify that. I mean the idea is to use some wiki, or other things to have documentation.
Maybe we can specify it in a README in javascript folder.