New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 & Ruby 3.1 #9328

Closed

ekohl wants to merge 28 commits into theforeman:develop from ekohl:rails-7-ruby-3.1

Member

ekohl commented Jul 30, 2022 •

edited

Loading

This is what I had to do to get Rails 7 to at least migrate and start up on Ruby 3.1. Then I noticed #9287 does a lot of the same work.

There's also a bunch of gem updates prepended to this which can be submitted separately. Split off PRs:

Member

theforeman-bot commented Jul 30, 2022

Issues: #32685

theforeman-bot added Waiting on contributor Needs testing Not yet reviewed GraphQL labels

ekohl mentioned this pull request

Closed

ekohl force-pushed the rails-7-ruby-3.1 branch from a9e3ffc to b832355 Compare

July 30, 2022 19:12

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

ekohl force-pushed the rails-7-ruby-3.1 branch from b832355 to c9902ae Compare

July 30, 2022 21:51

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

ekohl force-pushed the rails-7-ruby-3.1 branch from c9902ae to d5f05a4 Compare

August 2, 2022 11:26

theforeman-bot added Waiting on contributor and removed Waiting on contributor labels

Member Author

ekohl commented Aug 2, 2022

Rebased since some preparation work was merged. No real change compared to the previous version.

My plan is to submit the gem updates after branching, which would give us a much more solid base to work on. Then we can also look at the Zeitwerk changes in more detail.

theforeman-bot removed Needs testing Not yet reviewed labels

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

4 similar comments

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 25, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

Member

theforeman-bot commented Aug 31, 2022

@ekohl, this pull request is currently not mergeable. Please rebase against the develop branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream develop

This message was auto-generated by Foreman's prprocessor

ekohl force-pushed the rails-7-ruby-3.1 branch from d5f05a4 to 7175bd6 Compare

September 28, 2022 09:50

theforeman-bot added Needs re-review Waiting on contributor and removed Waiting on contributor labels

Member Author

ekohl commented Sep 28, 2022

This is still not ready for consumption, but since a lot of preparation work has been merged I've rebased this to make the PR a bit easier to grasp.

Member Author

ekohl commented Sep 28, 2022

Katello needs to update:

[2022-09-28T09:51:13.727Z] Bundler could not find compatible versions for gem "railties":
[2022-09-28T09:51:13.727Z]   In Gemfile:
[2022-09-28T09:51:13.727Z]     katello was resolved to 4.7.0.pre.master, which depends on
[2022-09-28T09:51:13.727Z]       angular-rails-templates (~> 1.1.0) was resolved to 1.1.0, which depends on
[2022-09-28T09:51:13.727Z]         railties (< 7, >= 4.2)
[2022-09-28T09:51:13.727Z] 
[2022-09-28T09:51:13.727Z]     rails (~> 7.0.3) was resolved to 7.0.3, which depends on
[2022-09-28T09:51:13.727Z]       railties (= 7.0.3)

Version 1.2 of that gem does support Rails 7.

Member

theforeman-bot commented Dec 29, 2022

Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now.
Feel free to reopen when you return to it. This is an automated process.

ofedoren and others added 23 commits

August 2, 2024 22:54


          Refs #29991 - Fix test

c6dda96


          Refs #29991 - Clean up some requirements

c543e5a


          Refs #29991 - Fix TelemetryHelper initialization warning

a99be7a


          Refs #29991 - Fix CsvExporter initialization warning

c730b0d


          Refs #29991 - Move net into app/lib

4766d1b


          Refs #29991 - Fix deprecation warnings for Settings

10e042a


          Refs #29991 - Fix deprecation warnings for AuditAssociations

4b74425


          Refs #29991 - Fix deprecation warnings for Foreman::Provision

0c12341


          Refs #29991 - Fix deprecations warnings for MeduimProviders/ReportSca…

a1481ad

…nner


          Refs #29991 - Preload STI differently

d330085


          Refs #29991 - Enable eager loading in test env


          Refs #29991 - Move http_proxy to app/lib

8824a9d


          Refs #29991 - Fix tests

2faea62


          Refs #29991 - Fix rubocop

b07f706


          Refs #29991 - Fix empty resources in tests

843068e


          Refs #29991 - Fix ReportScanner warning with plugins in mind

7787e59


          Refs #29991 - Apply review suggestions

c101239


          Refs #29991 - Deal with Nic model by explicit preloading

7574a2f


          Refs #29991 - Make VM an acronym

fd5e0eb


          Fixes #35431 - Update spring to 4.x

37b9dbc

Currently version 2 is used, but version 3 brings Ruby 3 support.
Version 4 is the latest. The only backwards incompatible changes they
mention[1] are requiring Ruby >= 2.7 and Rails >= 6.0, which is not a
problem for Foreman.

Version 3 enforces that cache_classes is turned off, in particular for
test environments.

[1]: https://github.com/rails/spring/blob/main/CHANGELOG.md


          Explicitly state belongs_to are optional

feede20

While there is a setting which we change, this allows running with Rails
5+ default settings.


          Switch to Rails 7

25dfa93

This drops the redirect_back_or_to method that Rails now natively
implements.

It also configures Foreman to raise errors on open redirects, similar to
what was implemented in 2517ba4. Rails
7.0 introduced this as a config option, but only enables it if you load
the 7.0 defaults while after this change it still loads the 6.1
defaults.


          Run tests with the number of processors

4509d6f

ekohl force-pushed the rails-7-ruby-3.1 branch from 4105eb4 to 4509d6f Compare

August 2, 2024 20:54

github-actions bot removed Inactive Stale labels

ekohl mentioned this pull request

Fixes #37825 - Upgrade Rails to 7.0 #10299

Open

Member Author

ekohl commented Sep 17, 2024

Closing in favor of #10299.

ekohl closed this

ekohl deleted the rails-7-ruby-3.1 branch

September 17, 2024 12:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs re-review Waiting on contributor