Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7 & Ruby 3.1 #9328

Closed
wants to merge 28 commits into from
Closed

Rails 7 & Ruby 3.1 #9328

wants to merge 28 commits into from

Commits on Aug 2, 2024

  1. Fixes #33895 - Set up Zeitwerk inflector 

    Zeitwerk uses constant to snake case to resolve the paths. If we want to
change some constants to be Uppercase, we need to use the inflector.
    @ekohl
    ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ff36e63 View commit details
    Browse the repository at this point in the history

  2. Fixes #29991 - Enable Zeitwerk

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ffe8d3a View commit details
    Browse the repository at this point in the history

  3. Refs #29991 - Remove require_dependency calls

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7665685 View commit details
    Browse the repository at this point in the history

  4. Refs #29991 - More PuppetCA renaming

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    42c9e15 View commit details
    Browse the repository at this point in the history

  5. Refs #29991 - Fix rubocop

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c633875 View commit details
    Browse the repository at this point in the history

  6. Refs #29991 - Fix test

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c6dda96 View commit details
    Browse the repository at this point in the history

  7. Refs #29991 - Clean up some requirements

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c543e5a View commit details
    Browse the repository at this point in the history

  8. Refs #29991 - Fix TelemetryHelper initialization warning

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a99be7a View commit details
    Browse the repository at this point in the history

  9. Refs #29991 - Fix CsvExporter initialization warning

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c730b0d View commit details
    Browse the repository at this point in the history

  10. Refs #29991 - Move net into app/lib

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4766d1b View commit details
    Browse the repository at this point in the history

  11. Refs #29991 - Fix deprecation warnings for Settings

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    10e042a View commit details
    Browse the repository at this point in the history

  12. Refs #29991 - Fix deprecation warnings for AuditAssociations

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4b74425 View commit details
    Browse the repository at this point in the history

  13. Refs #29991 - Fix deprecation warnings for Foreman::Provision

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0c12341 View commit details
    Browse the repository at this point in the history

  14. Refs #29991 - Fix deprecations warnings for MeduimProviders/ReportSca… 

    …nner
    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a1481ad View commit details
    Browse the repository at this point in the history

  15. Refs #29991 - Preload STI differently

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d330085 View commit details
    Browse the repository at this point in the history

  16. Refs #29991 - Enable eager loading in test env

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4235626 View commit details
    Browse the repository at this point in the history

  17. Refs #29991 - Move http_proxy to app/lib

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8824a9d View commit details
    Browse the repository at this point in the history

  18. Refs #29991 - Fix tests

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    2faea62 View commit details
    Browse the repository at this point in the history

  19. Refs #29991 - Fix rubocop

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b07f706 View commit details
    Browse the repository at this point in the history

  20. Refs #29991 - Fix empty resources in tests

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    843068e View commit details
    Browse the repository at this point in the history

  21. Refs #29991 - Fix ReportScanner warning with plugins in mind

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7787e59 View commit details
    Browse the repository at this point in the history

  22. Refs #29991 - Apply review suggestions

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c101239 View commit details
    Browse the repository at this point in the history

  23. Refs #29991 - Deal with Nic model by explicit preloading

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7574a2f View commit details
    Browse the repository at this point in the history

  24. Refs #29991 - Make VM an acronym

    @ofedoren @ekohl
    ofedoren authored and ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    fd5e0eb View commit details
    Browse the repository at this point in the history

  25. Fixes #35431 - Update spring to 4.x 

    Currently version 2 is used, but version 3 brings Ruby 3 support.
Version 4 is the latest. The only backwards incompatible changes they
mention[1] are requiring Ruby >= 2.7 and Rails >= 6.0, which is not a
problem for Foreman.

Version 3 enforces that cache_classes is turned off, in particular for
test environments.

[1]: https://github.com/rails/spring/blob/main/CHANGELOG.md
    @ekohl
    ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    37b9dbc View commit details
    Browse the repository at this point in the history

  26. Explicitly state belongs_to are optional 

    While there is a setting which we change, this allows running with Rails
5+ default settings.
    @ekohl
    ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    feede20 View commit details
    Browse the repository at this point in the history

  27. Switch to Rails 7 

    This drops the redirect_back_or_to method that Rails now natively
implements.

It also configures Foreman to raise errors on open redirects, similar to
what was implemented in 2517ba4. Rails
7.0 introduced this as a config option, but only enables it if you load
the 7.0 defaults while after this change it still loads the 6.1
defaults.
    @ekohl
    ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    25dfa93 View commit details
    Browse the repository at this point in the history

  28. Run tests with the number of processors

    @ekohl
    ekohl committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4509d6f View commit details
    Browse the repository at this point in the history