Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upcoming cocotb 2.0 #263

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

p12tic
Copy link

@p12tic p12tic commented Sep 6, 2024

This PR adds support for upcoming cocotb 2.0 in a way that supports the current 1.x release series as well.

If the maintainer deems necessary I can setup CI to have a separate set of configurations for a defined commit from cocotb master branch as well.

Coroutine support has been added to cocotb since around 1.4.0. In
upcoming v2.0 release generator support will be removed in favor of
coroutines. The minimum cocotb version supported by cocotb-test is 1.5,
accordingly there's no harm to upgrade tests to coroutines.
cocotb.result.TestFailure has been removed from upcoming cocotb 2.0
release.
cocotb v2.0 moves cocotb.config to cocotb_tools.config with otherwise
minimal changes.
cocotb v2.0 will prefix several environment variables with COCOTB_
prefix.
cocotb 2.0 will move its source to src/ subdirectory in their
repository.
@p12tic
Copy link
Author

p12tic commented Sep 6, 2024

CI fails because of

ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) file '/var/folders/q8/68hhzv8d7tq6gcjbsy0347_r0000gn/T/tmpq0fk6zxw.build-lib/cocotb/libs/libgpilog.so' for architecture x86_64
      clang: error: linker command failed with exit code 1 (use -v to see invocation

This error is present in other recent PRs and is unrelated to the current PR.

@themperek
Copy link
Owner

Thank you for work!

I was thinking about something much simpler (just drop support for 1.x but this is better).
Would you have time to add checking both for 1.x and 2.0 in CI? If not I will try to add this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants