-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abg)!: provide untyped fields always and typed ones if type available #1603
Conversation
77c3c5f
to
038cf30
Compare
6ff7eaa
to
edb501a
Compare
038cf30
to
c318448
Compare
edb501a
to
27ac4e9
Compare
c318448
to
2d36b76
Compare
27ac4e9
to
6245b49
Compare
2d36b76
to
2b90ea5
Compare
50b61d2
to
aec4604
Compare
3d2d1e4
to
15ec5e5
Compare
4396d5f
to
c0f0047
Compare
15ec5e5
to
4df2422
Compare
c0f0047
to
8598958
Compare
4df2422
to
5d905c7
Compare
8598958
to
1c2deee
Compare
5d905c7
to
4baa120
Compare
1c2deee
to
750cae1
Compare
750cae1
to
544b41d
Compare
4baa120
to
0e91c56
Compare
544b41d
to
dd67688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive, thanks! Just several minor things to discuss/fix.
...in/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/Generation.kt
Show resolved
Hide resolved
...in/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/Generation.kt
Outdated
Show resolved
Hide resolved
...egithub/workflows/actionbindinggenerator/bindingsfromunittests/ActionWithAllTypesOfInputs.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/generation/Generation.kt
Outdated
Show resolved
Hide resolved
dd67688
to
abfd5e0
Compare
abfd5e0
to
d513b9b
Compare
d513b9b
to
bc71f66
Compare
Additionally to the requested changes I also added a required tag to the KDoc for the cases where nullability does not reflect required status, i.e. in the typed class for typed properties. |
bc71f66
to
daa99c0
Compare
I approved, but it looks like CI didn't run. Any idea why? Retriggered by creating a copy of this PR. |
Fixes #1585
I have to confess, that I did not check every change in the unit test workflow files,
so they should probably be looked again closely. But I think it should have done the right thing.
Or at least how I envisioned it.
no typing =>
_Untyped
class with_Untyped
propertiesfull typing =>
_Untyped
class as above@Deprecated
with a replace hint for the typed class (works in the IDE),partly typing =>
_Untyped
and typed class as above_Untyped
property is added