-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(abg): Use "a.to(b)" instead of "a to b" #1607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2024
Vampire
force-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 19, 2024 13:15
3d2d1e4
to
15ec5e5
Compare
This was referenced Aug 19, 2024
krzema12
changed the title
fix(abg): Use "a.to(b)" instead of "a to b" or Kotlin Poet sometimes breaks before the "to" which is illegal
fix(abg): Use "a.to(b)" instead of "a to b"
Aug 19, 2024
Made the title a bit shorter by moving the rest to the description (I hope Graphite will merge it this way). |
krzema12
previously approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
I also changed the commit message accordingly to be on the safe side :-) |
Vampire
force-pushed
the
vampire/custom-types
branch
from
August 19, 2024 18:09
2b90ea5
to
e0e929e
Compare
Vampire
force-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 19, 2024 18:09
15ec5e5
to
4df2422
Compare
This was referenced Aug 20, 2024
Vampire
force-pushed
the
vampire/custom-types
branch
from
August 20, 2024 10:45
e0e929e
to
77a6d93
Compare
Vampire
force-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 20, 2024 10:45
4df2422
to
5d905c7
Compare
Or Kotlin Poet sometimes breaks before the "to" which is illegal.
Vampire
force-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 20, 2024 11:25
5d905c7
to
4baa120
Compare
krzema12
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or Kotlin Poet sometimes breaks before the "to" which is illegal.