✨ feat: follow user OS theme with JS disabled #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice!! Thank you 👍😊 |
welpo
commented
Sep 12, 2024
| @@ -107,6 +113,20 @@ | |||
| } | |||
| } | |||
|
|
|||
| @media (prefers-color-scheme: dark) { | |||
| :root:not([data-theme='light']) { | |||
| @include theme-variables('dark'); | |||
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses CSS variables to follow user OS settings even with JavaScript off. Now the atom feed preview follows the
default_theme, defaulting to user OS preference.Related issue
Idea from #330.
Changes
Updates CSS (adds 2KB), atom feed and feed styling xsl transformation.
Accessibility
No changes.
Type of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlcommentstheme.tomlcomments