fix: no hard dependency on nest_asyncio, use only when needed. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_no_nest_asyncio_dependency
branch
4 times, most recently
from
732efb9
to
b0e8c95
Compare
Only when we have a current event loop do we need nest_asyncio to be used and installed. In case where readinto is called from a thread (this is something we do in solara) which does not have an event loop yet, we should not need nest_asyncio. When needed, and not installed, we raise an error with an informative installation instruction.
maartenbreddels
force-pushed
the
fix_no_nest_asyncio_dependency
branch
from
b0e8c95
to
729fcf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only when we have a current event loop do we need nest_asyncio to be used and installed. In case where readinto is called from a thread (this is something we do in solara) which does not have an event loop yet, we should not need nest_asyncio.
When needed, and not installed, we raise an error with an informative installation instruction.