Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no hard dependency on nest_asyncio, use only when needed. #311

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: no hard dependency on nest_asyncio, use only when needed. #311

merged 1 commit into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. fix: no hard dependency on nest_asyncio, use only when needed. 

    Only when we have a current event loop do we need nest_asyncio to be
used and installed. In case where readinto is called from a thread
(this is something we do in solara) which does not have an event loop
yet, we should not need nest_asyncio.

When needed, and not installed, we raise an error with an informative
installation instruction.
    @maartenbreddels
    maartenbreddels committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    729fcf3 View commit details
    Browse the repository at this point in the history