Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

대시보드 페이지 반응형 구현 (issue #705) #708

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

brgndyy
Copy link
Contributor

@brgndyy brgndyy commented Oct 18, 2024

구현 요약

대시보드 페이지에 대한 반응형을 구현합니다.

연관 이슈

@brgndyy brgndyy added 🎨 프론트엔드 프론트엔드 관련 이슈 🚀 개선 성능의 개선 혹은 리팩토링 labels Oct 18, 2024
@brgndyy brgndyy self-assigned this Oct 18, 2024
Copy link
Contributor

@chosim-dvlpr chosim-dvlpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반응형 구현하시느라 고생많으셨습니다~! 코멘트 확인 부탁드릴게요!!

// if (process.env.NODE_ENV !== 'development') {
// return;
// }
async function enableMocking() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msw 모킹이 되어있어서 주석처리해주시면 될 것 같아요!!

Comment on lines +33 to +38
@media (max-width: 1024px) {
}

@media (max-width: 768px) {
width: 100%;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mediaQueries를 사용하면 breakpoint 관리가 더 쉬워질 것 같은데 어떠실까요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 프론트엔드 프론트엔드 관련 이슈 🚀 개선 성능의 개선 혹은 리팩토링
Projects
Status: ✏️ TODO
Development

Successfully merging this pull request may close these issues.

대시보드 페이지 반응형 구현
2 participants