-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
대시보드 페이지 반응형 구현 (issue #705) #708
Open
brgndyy
wants to merge
10
commits into
dev
Choose a base branch
from
feat/#705
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cd69616
refactor: 커스텀 뮤테이션 인자 변경
brgndyy 6d6a468
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy 7ada97b
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy 2edb8ea
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy 084c17a
remove: 파일 삭제
brgndyy 72d9638
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy b98620e
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy 195e287
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy 9b7665e
Merge branch 'dev' of https://github.com/woowacourse-teams/2024-devel…
brgndyy d528626
design: 대시보드 반응형 적용
brgndyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -283,40 +283,40 @@ export const router = createBrowserRouter(routes, { | |
basename: ROUTES.main, | ||
}); | ||
|
||
// async function enableMocking() { | ||
// if (process.env.NODE_ENV !== 'development') { | ||
// return; | ||
// } | ||
async function enableMocking() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. msw 모킹이 되어있어서 주석처리해주시면 될 것 같아요!! |
||
if (process.env.NODE_ENV !== 'development') { | ||
return; | ||
} | ||
|
||
// const { worker } = await import('./mocks/browser'); | ||
const { worker } = await import('./mocks/browser'); | ||
|
||
// // `worker.start()` returns a Promise that resolves | ||
// // once the Service Worker is up and ready to intercept requests. | ||
// return worker.start(); | ||
// } | ||
// `worker.start()` returns a Promise that resolves | ||
// once the Service Worker is up and ready to intercept requests. | ||
return worker.start(); | ||
} | ||
|
||
// enableMocking().then(() => { | ||
// root.render( | ||
// <React.StrictMode> | ||
// <QueryClientProvider client={queryClient}> | ||
// <ThemeProvider theme={theme}> | ||
// <ReactQueryDevtools initialIsOpen={false} /> | ||
// <GlobalStyle /> | ||
// <RouterProvider router={router} /> | ||
// </ThemeProvider> | ||
// </QueryClientProvider> | ||
// </React.StrictMode>, | ||
// ); | ||
// }); | ||
enableMocking().then(() => { | ||
root.render( | ||
<React.StrictMode> | ||
<QueryClientProvider client={queryClient}> | ||
<ThemeProvider theme={theme}> | ||
<ReactQueryDevtools initialIsOpen={false} /> | ||
<GlobalStyle /> | ||
<RouterProvider router={router} /> | ||
</ThemeProvider> | ||
</QueryClientProvider> | ||
</React.StrictMode>, | ||
); | ||
}); | ||
|
||
root.render( | ||
<React.StrictMode> | ||
<QueryClientProvider client={queryClient}> | ||
<ReactQueryDevtools /> | ||
<ThemeProvider theme={theme}> | ||
<GlobalStyle /> | ||
<RouterProvider router={router} /> | ||
</ThemeProvider> | ||
</QueryClientProvider> | ||
</React.StrictMode>, | ||
); | ||
// root.render( | ||
// <React.StrictMode> | ||
// <QueryClientProvider client={queryClient}> | ||
// <ReactQueryDevtools /> | ||
// <ThemeProvider theme={theme}> | ||
// <GlobalStyle /> | ||
// <RouterProvider router={router} /> | ||
// </ThemeProvider> | ||
// </QueryClientProvider> | ||
// </React.StrictMode>, | ||
// ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mediaQueries
를 사용하면 breakpoint 관리가 더 쉬워질 것 같은데 어떠실까요?