This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Added PHP 7.3 support - updated Travis CI configuration #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
suggested changes
Jan 8, 2019
| @@ -18,7 +18,7 @@ All notable changes to this project will be documented in this file, in reverse | |||
|
|
|||
| ### Removed | |||
|
|
|||
| - Nothing. | |||
| - [#223](https://github.com/zendframework/zend-mail/pull/223) removes support for zend-stdlib v2 releases. | |||
There was a problem hiding this comment.
v2 is no longer supported: https://framework.zend.com/long-term-support
and it's not fully compatible with PHP 7.3. No point to keep it here.
There was a problem hiding this comment.
include info in commit message and/or pr body. not just dumbly remove, then the maintainers don't have to ask either, but can already decide.
|
This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#20. |
|
This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.