Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Added PHP 7.3 support - updated Travis CI configuration #223

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Added PHP 7.3 support - updated Travis CI configuration #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a6c45c
Added PHP 7.3 support - updated Travis CI configuration
michalbundyra Dec 15, 2018
700d58b
Removed support for zend-stdlib v2 releases
michalbundyra Dec 23, 2018
89269be
Adds CHANGELOG entry for #223
michalbundyra Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
sudo: false

language: php

cache:
Expand Down Expand Up @@ -53,6 +51,15 @@ matrix:
- php: 7.2
env:
- DEPS=latest
- php: 7.3
env:
- DEPS=lowest
- php: 7.3
env:
- DEPS=locked
- php: 7.3
env:
- DEPS=latest

before_install:
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ All notable changes to this project will be documented in this file, in reverse

### Added

- Nothing.
- [#223](https://github.com/zendframework/zend-mail/pull/223) adds support for PHP 7.3.

### Changed

Expand All @@ -18,7 +18,7 @@ All notable changes to this project will be documented in this file, in reverse

### Removed

- Nothing.
- [#223](https://github.com/zendframework/zend-mail/pull/223) removes support for zend-stdlib v2 releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 is no longer supported: https://framework.zend.com/long-term-support
and it's not fully compatible with PHP 7.3. No point to keep it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include info in commit message and/or pr body. not just dumbly remove, then the maintainers don't have to ask either, but can already decide.


### Fixed

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"ext-iconv": "*",
"zendframework/zend-loader": "^2.5",
"zendframework/zend-mime": "^2.5",
"zendframework/zend-stdlib": "^2.7 || ^3.0",
"zendframework/zend-stdlib": "^3.2.1",
"zendframework/zend-validator": "^2.10.2",
"true/punycode": "^2.1"
},
Expand Down
12 changes: 6 additions & 6 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.