-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBX-94173] Cleanup after 526 failure email staging test #19066
Merged
SamStuckey
merged 1 commit into
master
from
dbx-94173/526_submission_failure_email_staging_test
Oct 25, 2024
Merged
[DBX-94173] Cleanup after 526 failure email staging test #19066
SamStuckey
merged 1 commit into
master
from
dbx-94173/526_submission_failure_email_staging_test
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamStuckey
force-pushed
the
dbx-94173/526_submission_failure_email_staging_test
branch
from
October 24, 2024 18:15
a872cf4
to
5dc0fe7
Compare
kylesoskin
previously approved these changes
Oct 24, 2024
SamStuckey
added
disability-experience
To manage benefits disability claims experience.
disability-compensation
Label used for Pull Requests that impact Disability Compensation claims (526EZ)
ZSF:Email
zero-silent-failures
labels
Oct 24, 2024
kylesoskin
previously approved these changes
Oct 24, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Oct 24, 2024
va-vfs-bot
temporarily deployed
to
dbx-94173/526_submission_failure_email_staging_test/main/main
October 24, 2024 18:34
Inactive
va-vfs-bot
temporarily deployed
to
dbx-94173/526_submission_failure_email_staging_test/main/main
October 24, 2024 20:10
Inactive
va-vfs-bot
temporarily deployed
to
dbx-94173/526_submission_failure_email_staging_test/main/main
October 24, 2024 20:53
Inactive
SamStuckey
force-pushed
the
dbx-94173/526_submission_failure_email_staging_test
branch
from
October 24, 2024 21:08
a01de12
to
cd46732
Compare
rmtolmach
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see Kyle previously approved the PR.
Backend-review-group approval confirmed. |
SamStuckey
deleted the
dbx-94173/526_submission_failure_email_staging_test
branch
October 25, 2024 18:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
disability-compensation
Label used for Pull Requests that impact Disability Compensation claims (526EZ)
disability-experience
To manage benefits disability claims experience.
require-backend-approval
test-passing
zero-silent-failures
ZSF:Email
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
files_submitted
andforms_submitted
arguments. After a cycle with design we agreed the best solution (which also avoides empty bullet points) is to simply interpolate 'None'Manual command line test code
Or the job can be manually called if a submission exists with the desired components
Screenshots
Case of Args present
NOTE: weird layout is being worked on by design, purpose here is simply to show correct interpolation
Case of 'None'
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria