[DBX-94173] Cleanup after 526 failure email staging test

[SamStuckey]

Summary

• This work is behind a feature toggle (flipper): YES
• Acoomodate new Product / Design ask to insert 'None' into email template if Vet-provided files and / or ancillary forms are blank
• Refactor for redability
• add nil check to error logging
• Update shared spec logic

Related issue(s)

• Current Ticket for testing
• Initial Ticket 1
• Initial Ticket 2
• Previous PR 1 (where this is used)
• Previous PR 2 (where this was originally added)

Testing done

• New code is covered by unit tests
• Email template rejects an empty array for the files_submitted and forms_submitted arguments. After a cycle with design we agreed the best solution (which also avoides empty bullet points) is to simply interpolate 'None'
• Command line testing of staging to ensure email template was generated

Manual command line test code

forms = ['VA Form 21-0781', 'VA Form 21-0781a']
files = ['thing.pdf', 'thang.txt']

# forms_submitted = 'None'
# files_submitted = 'None'

forms_submitted = forms
files_submitted = files

email_client = VaNotify::Service.new(Settings.vanotify.services.benefits_disability.api_key)
template_id = Settings.vanotify.services.benefits_disability.template_id
                      .form526_submission_failure_notification_template_id
email_client.send_email(
  email_address: <your email>,
  template_id:,
  personalisation: {
    first_name: "empty_strings",
    date_submitted: Date.today.strftime("%m/%d/%Y"),
    forms_submitted:,
    files_submitted:
  }
)

Or the job can be manually called if a submission exists with the desired components

Form526SubmissionFailureEmailJob.new.perform(submission.id)

Screenshots

Case of Args present

NOTE: weird layout is being worked on by design, purpose here is simply to show correct interpolation

Case of 'None'

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rmtolmach]

see Kyle previously approved the PR.

[github-actions]

Backend-review-group approval confirmed.