Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct output formats of seqtk_seq and seqtk_mergefa in all cases #6393

Merged
merged 16 commits into from
Oct 16, 2024

Conversation

RZ9082
Copy link
Contributor

@RZ9082 RZ9082 commented Oct 1, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Adjust output format when using -A force FASTA output (discard quality) to FASTA

dianichj and others added 7 commits September 24, 2024 14:21
- Restricted input formats to only FASTA and compressed FASTA files (.fasta, .fasta.gz). Removed support for FASTQ files.
- Updated the tool description and help section to accurately reflect that the tool only merges FASTA files.
- Improved the tool's clarity by ensuring it is used for its intended purpose: merging FASTA files only.
"Tool merges FASTA/Q files into a FASTA output and considers the quality threshold for FASTQ files when merging."

1. Clarified the -m option to handle ambiguous bases and conflicts (e.g., N and other IUPAC codes).
2. Improved help documentation with clearer examples and explanations.
3. Refined input parameter labels for better clarity and consistency.
edited echo command line back to #echo
@wm75
Copy link
Contributor

wm75 commented Oct 1, 2024

You need to bump the wrapper version. Maybe just this single one and don't change the macros one.

In addition, I think the fasta output of the tool would likely have to be fasta.gz in case the input is compressed (see the @CONDITIONAL_GZIP_OUT@ macro).

If you have the time, you could also pull in the changes from #6350 and fix the output format there. Very similar issue as yours: the output of that tool should always be fasta or fasta.gz, depending on input compression, but never fastq(.gz).

@RZ9082
Copy link
Contributor Author

RZ9082 commented Oct 2, 2024

You need to bump the wrapper version. Maybe just this single one and don't change the macros one.

In addition, I think the fasta output of the tool would likely have to be fasta.gz in case the input is compressed (see the @CONDITIONAL_GZIP_OUT@ macro).

If you have the time, you could also pull in the changes from #6350 and fix the output format there. Very similar issue as yours: the output of that tool should always be fasta or fasta.gz, depending on input compression, but never fastq(.gz).

seqtk seq actually produces also FASTQ as an output !

@wm75
Copy link
Contributor

wm75 commented Oct 2, 2024

yes, I realize. What I wanted to say is that the logic for handling output formats will be similar.

Copy link
Contributor Author

@RZ9082 RZ9082 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look good now? @wm75

tools/seqtk/seqtk_seq.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@wm75 wm75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a few suggestions.

tools/seqtk/macros.xml Outdated Show resolved Hide resolved
tools/seqtk/macros.xml Outdated Show resolved Hide resolved
@wm75 wm75 changed the title seqtk_seq - adjust output format for -A Ensure output formats of seqtk_seq and seqtk_mergefa match are correct in all cases Oct 16, 2024
@wm75 wm75 changed the title Ensure output formats of seqtk_seq and seqtk_mergefa match are correct in all cases Ensure correct output formats of seqtk_seq and seqtk_mergefa in all cases Oct 16, 2024
@bgruening bgruening merged commit 75d5141 into galaxyproject:main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants