Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgString Improvements #95

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

MsgString Improvements #95

wants to merge 4 commits into from
+35 −34

Conversation

llchrisll
Copy link
Owner

@llchrisll llchrisll commented Oct 5, 2024 •
edited
Loading

Improvement Focus:

  • Add more messages into helpmsgstr.lub
  • Collect feedback and make improvements to msgstringtable files
  • Improve msgstring_kr/_s.lub files

Lines as example, which were adjusted with the initial commit:
image
image

Template for Suggestions:

  1. File the line is located in (like msgstringtable.txt)
  2. Which feature/UI it's used in (like RODEX)

Notes:

  • The .csv file will be updated once all improvements have been added and approved.
  • The screenshots taken from an 2022-04-06 client.
  • This PR will stay open as long as needed, until no one has anything to improve on.

@llchrisll
This branch focuses on improvements on msgstringtable and any related…
36e2d5d 
… files, like helpmsgstr.lub and msgstring_kr/_s.lub

Note: The .csv file will be updated once all improvements have been added and approved.
@llchrisll
Quick fix of missing "
aaa8043
@llchrisll llchrisll added the enhancement Improvements label Oct 5, 2024
@llchrisll llchrisll self-assigned this Oct 5, 2024
@llchrisll llchrisll marked this pull request as draft October 5, 2024 15:20
@Haydrich
Copy link

Haydrich commented Oct 5, 2024

image-245
using Check instead of Validate Name

@llchrisll
Copy link
Owner Author

image-245 using Check instead of Validate Name

Like this?
image

@Haydrich
Copy link

Haydrich commented Oct 6, 2024

MSI_SKILL_INVENTORY_KINDCNT_OVER is used for Greed skill, that the player cannot used it when his inventory has less than 5 slots, Please secure some room in the inventory I dont feel safe with it? why "secure some room" I would like Please free up some inventory slots Im just confused. using slots or space? keep it up to you

crazy-arashi
crazy-arashi reviewed Oct 6, 2024
View reviewed changes
Tools/msgstringtable/msgstringtable_decoded.txt
@@ -2976,8 +2976,8 @@ MSI_SUCCESS,"Success"
MSI_RESET,"Return"
MSI_MANUFACTURED_MARRIAGERING_ITEM,"With Mr/Miss"
MSI_CHANGE_HOMUN_NAME,"The Homunculus's name will be changed to^0000ff^0000ff %s^000000^000000, Are you sure?"
MSI_BLOCK_CALL_PERMIT,"Call function is ON"
MSI_BLOCK_CALL_REJECT,"Call function is OFF"
MSI_BLOCK_CALL_PERMIT,"You can be \"Called\" with various skills (Emergency Call,...). (/call)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd go with "Player recalling skills is disabled/enabled" same for the bottom related call messages.

Copy link
Owner Author

@llchrisll llchrisll Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s fine this way, as it’s only affecting the player not the skills in general.

Tools/msgstringtable/msgstringtable_decoded.txt Outdated
@@ -3543,7 +3543,7 @@ MSI_ITEMSTORE_NOW_LOADING,"NOW LOADING..."
MSI_RODEX_BUTTON_DELETE,"Delete"
MSI_RODEX_BUTTON_ANSWER,"Reply"
MSI_RODEX_BUTTON_SEND,"Send"
MSI_RODEX_BUTTON_CONFIRM_ID,"Validate name"
MSI_RODEX_BUTTON_CONFIRM_ID,"Check Name"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with a simple, "Verify" or just keep it "Validate" since the error messages will tell you what's wrong anyways.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah would also work

@Haydrich
Copy link

Haydrich commented Oct 7, 2024

MSI_USESKILL_FAIL_WEIGHTOVER You can't use this Skill because you are over your Weight Limit. Mmm i don't know, i was thinking of deleting "this" to be You cannot use Skills while you are over your Weight Limit.

@Haydrich
Copy link

Haydrich commented Oct 9, 2024

MSI_GUILD_MAKE_GUILD_NONE_ITEM You need the necessary item to create a Guild. What about You need an Emperium to create a Guild

@llchrisll
Copy link
Owner Author

MSI_USESKILL_FAIL_WEIGHTOVER You can't use this Skill because you are over your Weight Limit. Mmm i don't know, i was thinking of deleting "this" to be You cannot use Skills while you are over your Weight Limit.

Nice catch, sounds better.

@llchrisll
Copy link
Owner Author

MSI_GUILD_MAKE_GUILD_NONE_ITEM You need the necessary item to create a Guild. What about You need an Emperium to create a Guild

Hmm for clarity purposes might be better.

@Haydrich
Copy link

Haydrich commented Oct 13, 2024 •
edited
Loading

MSI_RESERVE_CHANGE_CHARACTER_SLOT Moving Book Should be Moving Character

@Haydrich
Copy link

MSI_SELECTCHARWND_RESERVE_TO_DEL_CHAR Delete reservation Should be Delete Character
MSI_SELECTCHARWND_CANCEL_TO_RESERVE_CHAR Cancel reservation Should be Cancel Deletion
MSI_SELECTCHARWND_START_GAME Game start I would like to convert start to be capital Start Game Start

Haydrich
Haydrich reviewed Oct 16, 2024
View reviewed changes
Tools/msgstringtable/msgstringtable_decoded.txt
@@ -403,7 +403,7 @@ MSI_DISORGANIZE_GUILD_INVALIDKEY,"You have failed to disband the guild due to yo
MSI_DISORGANIZE_GUILD_MEMBEREXIST,"You have failed to disband the guild because there are guildsmen still present."
MSI_REQ_HOSTILE_GUILD,"Set this guild as an Antagonist"
MSI_SELECT_HAIR_COLOR,"Choose Hair Color"
MSI_GUILD_MAKE_GUILD_NONE_ITEM,"You need the necessary item to create a Guild."
MSI_GUILD_MAKE_GUILD_NONE_ITEM,"You need an Emperium to create a Guild"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MSI_GUILD_MAKE_GUILD_NONE_ITEM,"You need an Emperium to create a Guild"
MSI_GUILD_MAKE_GUILD_NONE_ITEM,"You need an Emperium to create a Guild."

@Haydrich
Copy link

Haydrich commented Nov 3, 2024 •
edited
Loading

MSI_ACCOUNT_LIMITED_DB_NAME Item DB Name to Item Name
MSI_ACCOUNT_LIMITED_TOOL_DB_NUMBER Item DB Number to Item ID
MSI_ACCOUNT_LIMITED_TOOL_SELL_COUNT Number of Sale to Item Quantity or Qty Depending on the empty.
MSI_ACCOUNT_LIMITED_TOOL_SELL_STARTTIME Sale Start Time to Sale Start Date
MSI_ACCOUNT_LIMITED_TOOL_SELL_ENDTIME End of Sale to Sale End Date I would use Expiry instead of End but the empty.
MSI_ACCOUNT_LIMITED_SALE_ITEM_START_DATE Sales Period to Sale Start Date
MSI_ACCOUNT_LIMITED_SALE_ITEM_NUM Available per account Actually this one requires a lot of thinking, depending on the empty, it's Maybe be Per Account or Available, So. Do what you are supposed to do.
MSI_ACCOUNT_LIMITED_SALE_ITEM_LIMIT_NUM Limit: %d each to Limit: %d or Limit: %d ea.
MSI_ACCOUNT_LIMITED_TOOL_RESULT_NEWFORMAT I don't know if this one possibly use a \n form
Item Name: %s\nQuantity: %d\nSale Starts: Month: %d | Day: %d | Hour: %d | Minutes: %d | Year: %d\nSale Ends: Month: %d | Day: %d | Hour: %d | Minutes: %d
MSI_ACCOUNT_LIMITED_SALE_ITEM_NEXT_NEWDATE ~ %d minutes %d hours %d day %d month %d year to
~ %d Y %d M %d D %d:%d or Adding Hour and Minutes but it takes more empty.
MSI_BARGAINSALE_TOOLWND_APPLY_SUCCESS_MSG Registration Successful
MSI_BARGAINSALE_CASHSHOP_CHECK_COUNT_MSG Item stock is low to Item stock is limited
I guess this is all for now.

@Haydrich
Copy link

Haydrich commented Nov 3, 2024

MSI_BLOCK_CALL_PERMIT and MSI_BLOCK_CALL_REJECT They should be small sentences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-arashi crazy-arashi crazy-arashi left review comments

@Haydrich Haydrich Haydrich left review comments

Assignees

@llchrisll llchrisll

Labels
enhancement Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llchrisll @Haydrich @crazy-arashi