-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest polkadot-sdk@1.5
release
#137
Conversation
99b2457
to
2203e3f
Compare
67fad4f
to
889cb10
Compare
6eb085d
to
288bc02
Compare
d4aac62
to
77ae24a
Compare
@bkchr @ggwpez guys, any idea what is wrong here?
I just see that this error message is coming from here. I thought it is related to the
but it is not. Locally it works (I know, I know...), maybe I missed something to port, will investigate Monday. |
@bkontur change the stable toolchain installation to use the default profile. We need rust-src to be installed. |
dae97a5
to
76ac2f3
Compare
It should fix on the next update: Swatinem/rust-cache#172 (comment) |
system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs
Show resolved
Hide resolved
69b9a5e
to
01953fd
Compare
Its a two step process, first we do a runtime upgrade without them and then in the next one we add these migrations to delete the |
pallet-staking bump >= 26 will introduce a paged exposure feature that will break some dapps if they have not integrated the changes. Is it possible to upgrade only Kusama and have it running only on Kusama for a while before upgrading Polkadot? cc: @jakoblell |
This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com>
This is a cherry-pick of #3094 (patch to `release-polkadot-v1.5.0`). This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: command-bot <>
…-1.5 # Conflicts: # Cargo.lock
Fellows, please review this bump. The only thing missing is the failed |
balances: endowed_accounts | ||
.iter() | ||
.cloned() | ||
.map(|k| (k, ASSET_HUB_POLKADOT_ED * 4096)) | ||
.map(|k| (k, ASSET_HUB_POLKADOT_ED * 4096 * 4096)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional increase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just genesis configs for testing, so changing them is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but still might affect tests, wanted to point in case of accidental change
); | ||
} | ||
|
||
// TODO: Encointer pallets does not have compatible `polkadot-sdk` versions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be very easy to forget to update this when something updated in constants. may be we should try to drop some dependancies from constant crates. Should we have at least an issue for thus?
Based on bump to [`polkadot-sdk@1.5.0`](#137). Attached result of `cargo upgrade -v --pinned --incompatible` [cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/14044160/cargo-upgrade-version-bump.log) _Note: Encointer was not upgraded (because its pallet references `polkadot@1.3.0` release)._ ## ~~For reviewers~~ ~~This PR is against `polkadot-fellows`'s main to bring it to the fellows repo, but if you want to see a real diff relevant to the `polkadot-sdk@1.6.0` update please check: bkontur/runtimes@bko-bump-to-1.5...bkontur:runtimes:bko-bump-to-1.6.~~ ## TODO - [x] fix compilation - [x] fix integration tests - [x] fix benchmarks (also try them) - `collectives-polkadot` `payout` - [ ] ~~Does not require a CHANGELOG entry~~ - [x] `warning: use of deprecated struct `staging_xcm_builder::CurrencyAdapter`: Use `FungibleAdapter` instead` - [ ] search for `TODO:(PR#159) change to FungibleAdapter` and/or wait for paritytech/polkadot-sdk#3287 - [x] patch for `pallet-nomination-pools` migration fix paritytech/polkadot-sdk#3093 - will be fixed here #188 (comment) - [x] patch for `xcm-executor` fix (for 1.6.0) e.g. paritytech/polkadot-sdk#3174 - [x] check/fix coretime stuff for Kusama/Polkadot - search for `// TODO:(PR#159)(PR#1694)` - see [comment](#159 (comment)) - fixed by bkontur#3 - [x] check the `MaxControllersInDeprecationBatch`https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492361038 - [x] check `pallet_identity::Config` for Kusama and Polkadot https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492363866 --------- Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
…chain (#174) This PR does two things: 1) (tiny refactoring) adds `TRANSACTION_BYTE_FEE` constant to `system-parachains-constants` crate. We are using the same value (`1 * MILLICENTS`) across all chains, so it makes sense to move it there; 2) changes default value of governance-controlled `XcmBridgeHubRouterByteFee` constant (which is used to cover the cost of message delivery within the remote consensus) to use `TRANSACTION_BYTE_FEE` of the bridged chain (also does 1:5/5:1 conversion). Since governance has not set value of this constant yet, we are changing the default value here, in the code. ~The failing test is fixed by the #137, so it makes sense to merge this PR only after #137~ Updated --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
- [x] Adds asset hub and bridge hub to Kusama and Polkadot runtimes - [x] based off #108 - needs to be merged first - [x] snowbridge crates needs to be published on crates.io - depends on `polkadot-sdk 1.7.0` - [x] MessageQueue Pallet is not configured on Kusama and Polkadot asset hub - added in #137 - [x] `FeeManager` `handle_fee` misses reason, crate needs to be updated I think cc @vgeddes @alistair-singh @yrong @musnit --------- Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: brenzi <brenzi@users.noreply.github.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>
Attached result of
cargo upgrade -v --pinned --incompatible
cargo-upgrade-version-bump.logE.g.:
frame-support
from25.0.0
to27.0.0
Note: Encointer was not upgraded (because its pallet references
polkadot@1.3.0
release).TODO
pallet-nomination-pools
migration fix Backport of fix Pools 6->7 migration (#2942) paritytech/polkadot-sdk#3094xcm-executor
fix Backport XCM fixes to 1.5.0 paritytech/polkadot-sdk#3174TODO:(PR#137) - wait for xcm-executor patch
(missingFrameTransactionalProcessor
)MaxExposurePageSize = 512
/MaxNominators = 512
for Kusama/PolkadotCloses: #113