Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class files #376

Closed
wants to merge 6 commits into from
Closed

First class files #376

wants to merge 6 commits into from

Conversation

illusional
Copy link
Collaborator

Should this consider sequence groups first?

Broad overview of changes:

  • Make a File a first class citizen
  • Allow analysis to support multiple outputs (keyed as an object)
  • Support stronger sequence files

Eventually goals:

  • Subscribe to change notifications from GCS, and action deletes / updates.
    • Still to determine appropriate behaviour, should analysis entries get invalidated and reinserted?
    • How should we ensure getting old information is relevant, should it use system-versioned tables to look at particular points in time?

# Conflicts:
#	db/project.xml
# Conflicts:
#	models/models/analysis.py
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c902cd) 71.64% compared to head (bddebdf) 71.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #376   +/-   ##
=======================================
  Coverage   71.64%   71.65%           
=======================================
  Files          90       90           
  Lines        7686     7688    +2     
=======================================
+ Hits         5507     5509    +2     
  Misses       2179     2179           
Impacted Files Coverage Δ
db/python/tables/analysis.py 36.40% <100.00%> (+0.31%) ⬆️
models/models/analysis.py 96.55% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@illusional illusional closed this Dec 12, 2023
@nevoodoo nevoodoo mentioned this pull request Feb 2, 2024
6 tasks
@nevoodoo nevoodoo mentioned this pull request Jul 5, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants