-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project and sample id filter #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me. Have you been able to test that it works locally?
Yup it works locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also LGTM, and the filter seems to be working for you locally
* Fix Mismatched Samples count (#498) * fixed API turning all smaples as true and fixed project grid showing all samples not just active ones * linting * moved active check * moved active type conversion to sample model * Post sg UI fixes (#501) * small fixes to project and analysis grids * Added link to css overflow blogpost * Update backup script to fetch new credentials (#502) * Fix get analysis by id query (#503) * Fix get analysis by ID (+ simplify analysis tests) * Linting * Cohort builder schema (#497) * Cohort builder schema * Fix bad copy-paste * Fix nullable specification * Add internal pid to ParticipantUpsert constructor from ParsedParticipant object (#505) * Add blob.reload() call to cloudhelper get_gcs_blob (#506) * Audit module and test update for SG changes (#509) * Audit module and test update for SG changes * Remove datasets list from audithelper * Typehint fixes for linting * Add project and sample id filter (#511) * Allows uses to filter on sample ID within a project * remove prints * Bump version: 6.0.6 -> 6.1.0 (#512) * Update deploy.yaml (#517) * Update deploy.yaml * Ignore pyenv and dotenv files * update names to kebab-case * add new line to make end-of-file-fixer happy * ignore mypy cache --------- Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com> --------- Co-authored-by: danielreti <47542969+danielreti@users.noreply.github.com> Co-authored-by: Michael Franklin <michael.franklin@populationgenomics.org.au> Co-authored-by: EddieLF <34049565+EddieLF@users.noreply.github.com> Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com>
Closes #510
I tagged everyone for an FYI and also so I can get 3 sanity checks