Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix family external id participant grid filter #982

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

dancoates
Copy link
Contributor

  • Rolls back changes to value filter introduced in Uplift code quality in metamist repo #957, this is just to allow for this quick fix, they can be re-added later when we have time to test and bugfix them
  • Adds support for querying participant grid by family external id

@dancoates dancoates force-pushed the fix-family-external-id-pgrid-filter branch from f1b8ac1 to 78fbf83 Compare October 30, 2024 01:05
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (0d9e0bd) to head (78fbf83).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
db/python/tables/participant.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #982      +/-   ##
==========================================
- Coverage   81.56%   81.54%   -0.03%     
==========================================
  Files         184      184              
  Lines       15957    15965       +8     
==========================================
+ Hits        13016    13018       +2     
- Misses       2941     2947       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dancoates dancoates merged commit 5c83cd8 into dev Oct 30, 2024
8 of 9 checks passed
@dancoates dancoates deleted the fix-family-external-id-pgrid-filter branch October 30, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants