Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend debug ROM is not cached. #866

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Recommend debug ROM is not cached. #866

merged 1 commit into from
Sep 11, 2023

Conversation

timsifive
Copy link
Contributor

The performance of this code doesn't matter (compared to how slow JTAG is), and the fewer side effects debugging has, the better.

The performance of this code doesn't matter (compared to how slow JTAG
is), and the fewer side effects debugging has, the better.
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK with me. The only thing that makes me mildly nervous is that changes like this (even though it's no big deal and in a non-normative appendix) could be an excuse to further delay things.

@timsifive timsifive added the 1.1 label Aug 15, 2023
@timsifive
Copy link
Contributor Author

Good point. Let's hold it until 1.1.

@timsifive
Copy link
Contributor Author

We've allowed in a couple other clarification changes, so I'm merging this one too.

@timsifive timsifive added 1.0 and removed 1.1 labels Sep 11, 2023
@timsifive timsifive merged commit a81d9ed into master Sep 11, 2023
1 check passed
@timsifive timsifive deleted the execute_cache branch September 11, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants