Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two code-analyser bugs #282

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Fix two code-analyser bugs #282

wants to merge 1 commit into from

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Feb 4, 2023

We have a static code analyser running and it triggered on these two statements.

The return 0 can never be reached.

And one should only invert booleans with !. Not integers. The std::set used has an .insert option which returns if it was actually added. So using that instead.

@Timple Timple mentioned this pull request Feb 4, 2023
Merged
@ct2034 ct2034 added the ros1 PR tackling a ROS1 branch label Feb 13, 2023
peci1
peci1 approved these changes Sep 6, 2024
View reviewed changes
Copy link

@peci1 peci1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this has been successfully merged into ro2, I don't see any reason to not merge it to noetic-devel, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peci1 peci1 peci1 approved these changes

Assignees
No one assigned
Labels
ros1 PR tackling a ROS1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timple @peci1 @ct2034