[mc_control] Properly apply contact DoF when using the deprecated method #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #250, we noticed that the old method of setting contact DoF is no longer working.
For example:
results in two contacts set with full dof (
1 1 1 1 1 1
) instead of (0 0 1 1 1 0
). This is because theContact::from_mc_rbdyn
doesn't take into account the contact's dof set in the constraint.As a side note, tutorials haven't been updated and suggest using deprecated APIs:
Requires jrl-umi3218/Tasks#80