Add unsafe Rust skill V1 and preserve predecessor pilot - #3520
Merged
Conversation
This was referenced Aug 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63e27557e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshlf
force-pushed
the
G6f4nmapfoz5ur4camwh2yhyazexc2lct
branch
2 times, most recently
from
August 29, 2026 11:11
6dfbeb8 to
788854e
Compare
joshlf
force-pushed
the
G6f4nmapfoz5ur4camwh2yhyazexc2lct
branch
from
September 1, 2026 22:15
788854e to
de6c8f1
Compare
jswrenn
approved these changes
Sep 2, 2026
joshlf
enabled auto-merge
September 2, 2026 19:52
Introduce a proof-oriented unsafe Rust authoring and audit skill. Treat safety documentation as an English-language theorem and each SAFETY comment as its proof, with every material premise grounded in exact versioned Rust Reference or standard-library text or recorded conspicuously in the TCB. Require obligation-first review, local invariant composition, adversarial caller reasoning, explicit dependency trust, complete safe-API and configuration surfaces, documented postconditions, and proof-grade audit artifacts. Include the conditional abstraction-design workflow, module-boundary discipline, API-evolution and SemVer analysis, generated-code coverage, TCB and report templates, and a source catalog and evaluation plan. Preserve the paired exploratory smoke test that preceded this V1 snapshot. Ten fresh source-only agents reviewed synthetic vulnerable/fixed code, a historical zerocopy defect/fix pair, and current zerocopy. The treatment retained complete known-defect recall and improved authority, configuration, surface, TCB, and report closure, while the current-code challenge exposed missed version applicability, literal contract clauses, and indirect derivations. The exact predecessor skill archive and several raw pilot artifacts were not retained. Record its digest and results without claiming a byte-exact predecessor-to-V1 diff. The pilot used procedural rather than hardened isolation, one replicate per cell, and cannot establish release readiness. gherrit-pr-id: G6f4nmapfoz5ur4camwh2yhyazexc2lct Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
joshlf
force-pushed
the
G6f4nmapfoz5ur4camwh2yhyazexc2lct
branch
from
September 2, 2026 20:45
de6c8f1 to
2251f7e
Compare
This was referenced Sep 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a proof-oriented unsafe Rust authoring and audit skill. Treat safety
documentation as an English-language theorem and each SAFETY comment as its
proof, with every material premise grounded in exact versioned Rust Reference
or standard-library text or recorded conspicuously in the TCB.
Require obligation-first review, local invariant composition, adversarial
caller reasoning, explicit dependency trust, complete safe-API and
configuration surfaces, documented postconditions, and proof-grade audit
artifacts. Include the conditional abstraction-design workflow, module-boundary
discipline, API-evolution and SemVer analysis, generated-code coverage, TCB and
report templates, and a source catalog and evaluation plan.
Preserve the paired exploratory smoke test that preceded this V1 snapshot. Ten
fresh source-only agents reviewed synthetic vulnerable/fixed code, a historical
zerocopy defect/fix pair, and current zerocopy. The treatment retained complete
known-defect recall and improved authority, configuration, surface, TCB, and
report closure, while the current-code challenge exposed missed version
applicability, literal contract clauses, and indirect derivations.
The exact predecessor skill archive and several raw pilot artifacts were not
retained. Record its digest and results without claiming a byte-exact
predecessor-to-V1 diff. The pilot used procedural rather than hardened
isolation, one replicate per cell, and cannot establish release readiness.
Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
This PR is on branch codex/unsafe-rust-stack.
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G6f4nmapfoz5ur4camwh2yhyazexc2lct && git checkout -b pr-G6f4nmapfoz5ur4camwh2yhyazexc2lct FETCH_HEADCheckout
git fetch origin refs/heads/G6f4nmapfoz5ur4camwh2yhyazexc2lct && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G6f4nmapfoz5ur4camwh2yhyazexc2lct && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.