Revise unsafe Rust skill around domain and verdict certificates - #3524
Merged
Conversation
This was referenced Aug 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gthyz3viupsc7cxzrbqaql6qitqmx2ews #3524 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36cbde8c27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
from
August 29, 2026 10:42
61a4fac to
5c20eec
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
August 29, 2026 10:42
36cbde8 to
56882c7
Compare
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
from
August 29, 2026 11:11
5c20eec to
d721d5a
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
August 29, 2026 11:11
56882c7 to
b87ebc8
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 1, 2026 22:15
b87ebc8 to
9401243
Compare
jswrenn
approved these changes
Sep 2, 2026
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
from
September 2, 2026 20:45
0a06c00 to
47dddc8
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 2, 2026 20:45
9401243 to
5d3022d
Compare
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 2, 2026 21:51
5d3022d to
edf9e1a
Compare
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
from
September 2, 2026 21:51
47dddc8 to
134ad23
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 2, 2026 22:28
edf9e1a to
96e9d25
Compare
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
2 times, most recently
from
September 2, 2026 23:04
2ba2538 to
80a9536
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 2, 2026 23:04
96e9d25 to
36a04b4
Compare
joshlf
force-pushed
the
Gthyz3viupsc7cxzrbqaql6qitqmx2ews
branch
from
September 3, 2026 00:07
80a9536 to
f6797fe
Compare
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 3, 2026 00:07
36a04b4 to
53958dd
Compare
Respond holistically to the concentrated V2 failures. Define Required as the exact cases quantified by a claim and Covered as the cases whose obligations have complete applicable derivations. Preserve ranges, unions, exclusions, and conditional policies symbolically; make every normalization, enumeration, partition, merge, and exclusion a checked proof step; and require Required to be contained in Covered before issuing PROVED. Require every multi-release affirmative claim to use a parametric proof, an exhaustive applicable partition, or an exact proposition-preserving compatibility premise. Endpoints, sparse samples, CI, stability badges, and an audit cutoff do not establish an interval. Replace informal verdict selection with quantifier-sensitive certificates. UNPROVED records an incomplete universal derivation. UNSOUND requires a valid in-scope use, reachability, a false exact safety proposition, and an applicable UB consequence; once all four links close, do not demand a universal positive lemma. CONTRACT-BROKEN continues to require a UB-free falsifying execution. Update audit and TCB templates to retain domain transformations, coverage containment, version bases, and complete verdict certificates. Add the maintainer rationale and traceability document so later changes preserve this proof model without leaking design history into the runtime instructions. gherrit-pr-id: Gcbutfa3xssppp2tjpxo2fjo6kguufo6t Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
joshlf
force-pushed
the
Gcbutfa3xssppp2tjpxo2fjo6kguufo6t
branch
from
September 3, 2026 01:00
53958dd to
c37eb34
Compare
joshlf
enabled auto-merge
September 3, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respond holistically to the concentrated V2 failures.
Define Required as the exact cases quantified by a claim and Covered as the
cases whose obligations have complete applicable derivations. Preserve ranges,
unions, exclusions, and conditional policies symbolically; make every
normalization, enumeration, partition, merge, and exclusion a checked proof
step; and require Required to be contained in Covered before issuing PROVED.
Require every multi-release affirmative claim to use a parametric proof, an
exhaustive applicable partition, or an exact proposition-preserving
compatibility premise. Endpoints, sparse samples, CI, stability badges, and an
audit cutoff do not establish an interval.
Replace informal verdict selection with quantifier-sensitive certificates.
UNPROVED records an incomplete universal derivation. UNSOUND requires a valid
in-scope use, reachability, a false exact safety proposition, and an applicable
UB consequence; once all four links close, do not demand a universal positive
lemma. CONTRACT-BROKEN continues to require a UB-free falsifying execution.
Update audit and TCB templates to retain domain transformations, coverage
containment, version bases, and complete verdict certificates. Add the
maintainer rationale and traceability document so later changes preserve this
proof model without leaking design history into the runtime instructions.
Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
This PR is on branch codex/unsafe-rust-stack.
Latest Update: v13 — Compare vs v12
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gcbutfa3xssppp2tjpxo2fjo6kguufo6t && git checkout -b pr-Gcbutfa3xssppp2tjpxo2fjo6kguufo6t FETCH_HEADCheckout
git fetch origin refs/heads/Gcbutfa3xssppp2tjpxo2fjo6kguufo6t && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gcbutfa3xssppp2tjpxo2fjo6kguufo6t && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.