Require evidence-bearing proof kernels in unsafe Rust V5 - #3536
Open
joshlf wants to merge 1 commit into
Open
Conversation
This was referenced Aug 3, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 552516db54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+297
to
+299
| implementer obligation owned outside the audited scope—including an | ||
| obligation imposed on caller or implementer code supplied by the witness—is | ||
| satisfied. No prose-only condition is imposed on a safe boundary. Do not |
There was a problem hiding this comment.
When the audited scope includes an unsafe API, this instruction permits its boundary assertion to be left false even when that assertion is a documented caller precondition. For example, an out-of-range call to an audited get_unchecked-style API could then be certified as a valid witness and its expected UB reported as UNSOUND, contradicting SKILL.md's definition that valid uses of unsafe APIs satisfy all documented safety obligations. Distinguish caller preconditions—which must be satisfied regardless of where their contract is declared—from implementation or impl assertions that the audit is testing.
Useful? React with 👍 / 👎.
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
August 29, 2026 10:42
2a5da41 to
a94d5db
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
August 29, 2026 10:42
552516d to
546936e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x #3536 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
August 29, 2026 11:11
546936e to
8d7339d
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
August 29, 2026 11:11
a94d5db to
3e392c9
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 1, 2026 22:15
3e392c9 to
9a67406
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 1, 2026 22:15
8d7339d to
7887aaf
Compare
jswrenn
approved these changes
Sep 2, 2026
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 2, 2026 20:45
7887aaf to
4cde1af
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 2, 2026 20:45
9a67406 to
425efb3
Compare
This was referenced Sep 2, 2026
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 2, 2026 21:51
425efb3 to
ddf5fe7
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
2 times, most recently
from
September 2, 2026 22:28
5d5644a to
51b9b60
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
2 times, most recently
from
September 2, 2026 23:04
41e1bca to
b151d20
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
3 times, most recently
from
September 3, 2026 01:00
ec78a58 to
b99ddae
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
2 times, most recently
from
September 3, 2026 01:33
1d76861 to
b6762cd
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 3, 2026 01:33
b99ddae to
bd8bf74
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 3, 2026 02:26
b6762cd to
9011a48
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
2 times, most recently
from
September 3, 2026 03:03
26e4b89 to
f52021f
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
2 times, most recently
from
September 3, 2026 04:06
986c4e6 to
6177ec2
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 3, 2026 04:06
f52021f to
0f13ff8
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 3, 2026 04:42
6177ec2 to
11844c0
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
2 times, most recently
from
September 3, 2026 05:14
24450e1 to
68cc8b3
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 3, 2026 05:14
11844c0 to
387a2ec
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 3, 2026 05:47
68cc8b3 to
fd3c9d2
Compare
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
2 times, most recently
from
September 3, 2026 06:17
c88d2f4 to
a353992
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 3, 2026 06:17
fd3c9d2 to
18f87cf
Compare
Revise the runtime skill around the root cause of the V4 failures: agents must not silently promote visible Rust syntax or artifact text into the semantic proposition needed by an unsafe-code proof. Require every load-bearing premise to state its exact proposition, provenance, applicability domain, and downstream consumer. Distinguish directly observed artifact facts from claims about Rust execution, typing, arithmetic, control flow, library behavior, or caller obligations; the latter must follow from applicable authoritative text, an explicit admitted TCB premise, or a checked derivation. Verify that cited text entails the proposition in the direction the proof uses it rather than merely mentioning related concepts. Add a valid-use certificate that identifies why the counterexample or proof case is admitted at each safe API boundary. Track root blockers separately from the atoms that depend on them so one missing semantic bridge cannot be hidden by many repeated conclusions. When an auditor must reconstruct a proof that the code comment does not contain, require the report to expose that reconstructed proof for maintainer review instead of silently accepting the site. Keep the existing exact-domain, set-relation, staged-construction, whole-execution, verdict-certificate, local-invariant, and abstraction-design discipline. Express the new requirements as a compact evidence-bearing proof kernel, not as a list of syntax forms or evaluated fixtures. gherrit-pr-id: Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3 Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
joshlf
force-pushed
the
Gquwn2yzvxejg4lkqiqoaaowxzxbmj62x
branch
from
September 3, 2026 06:47
a353992 to
ff01045
Compare
joshlf
force-pushed
the
Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3
branch
from
September 3, 2026 06:47
18f87cf to
8376fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise the runtime skill around the root cause of the V4 failures: agents must
not silently promote visible Rust syntax or artifact text into the semantic
proposition needed by an unsafe-code proof.
Require every load-bearing premise to state its exact proposition, provenance,
applicability domain, and downstream consumer. Distinguish directly observed
artifact facts from claims about Rust execution, typing, arithmetic, control
flow, library behavior, or caller obligations; the latter must follow from
applicable authoritative text, an explicit admitted TCB premise, or a checked
derivation. Verify that cited text entails the proposition in the direction the
proof uses it rather than merely mentioning related concepts.
Add a valid-use certificate that identifies why the counterexample or proof
case is admitted at each safe API boundary. Track root blockers separately from
the atoms that depend on them so one missing semantic bridge cannot be hidden by
many repeated conclusions. When an auditor must reconstruct a proof that the
code comment does not contain, require the report to expose that reconstructed
proof for maintainer review instead of silently accepting the site.
Keep the existing exact-domain, set-relation, staged-construction,
whole-execution, verdict-certificate, local-invariant, and abstraction-design
discipline. Express the new requirements as a compact evidence-bearing proof
kernel, not as a list of syntax forms or evaluated fixtures.
Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
This PR is on branch codex/unsafe-rust-stack.
Latest Update: v22 — Compare vs v21
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3 && git checkout -b pr-Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3 FETCH_HEADCheckout
git fetch origin refs/heads/Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gj24u57i5qq6wbmrnwypu7cy7dupt2mt3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.