Revise the unsafe Rust skill after the V3 evaluation - #3531
Merged
Conversation
This was referenced Aug 3, 2026
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
August 29, 2026 10:42
bd3c8b8 to
b873e00
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6093 6093
=======================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
August 29, 2026 11:11
7a81574 to
86a3709
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
August 29, 2026 11:11
b873e00 to
4179be5
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 1, 2026 22:15
4179be5 to
7b65115
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 1, 2026 22:15
86a3709 to
3582b7f
Compare
jswrenn
approved these changes
Sep 2, 2026
jswrenn
approved these changes
Sep 2, 2026
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 2, 2026 20:45
7b65115 to
951c6a4
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 2, 2026 20:45
3582b7f to
2d7c4b6
Compare
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 2, 2026 21:51
2d7c4b6 to
e91ec81
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 2, 2026 21:51
951c6a4 to
d30ea6a
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 2, 2026 22:28
e91ec81 to
41004bf
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
2 times, most recently
from
September 2, 2026 23:04
28024d8 to
bc2f0a8
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
2 times, most recently
from
September 3, 2026 00:07
92dc9bb to
f79c76b
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
2 times, most recently
from
September 3, 2026 01:00
bb47452 to
f08e1e6
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 3, 2026 01:33
4c01c14 to
9c811a3
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 3, 2026 01:33
f08e1e6 to
61b1bbb
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 3, 2026 02:26
9c811a3 to
a169761
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 3, 2026 02:26
61b1bbb to
8b24322
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 3, 2026 03:03
a169761 to
65b815a
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 3, 2026 03:03
8b24322 to
25175d2
Compare
joshlf
force-pushed
the
Glzlcl663nbggljjqi64x7gs3yyw5b7ys
branch
from
September 3, 2026 04:06
65b815a to
ad171d1
Compare
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 3, 2026 04:06
25175d2 to
36a2372
Compare
Rework the proof model around lossless representations and locally checkable certificates, following the V3 gate failure and qualitative diagnosis. Require an explicit case domain for each quantified claim and describe how inputs map to obligation fibers. For equality, containment, disjointness, and incomparability claims, require the exact direction-specific certificate and the separating witnesses the relation demands. Treat feature, target, allocator, toolchain, and policy expressions as semantic sets whose operators must be justified before their denotations may be composed. Model ordered and fallible construction as a staged relation rather than an endpoint summary. Require transformations to retain enough information to reverse or independently check the derivation, and reject prose such as by inspection or all cases when the case mapping is not shown. Scope counterexamples to the verdict actually requested: one complete existential unsoundness witness closes UNSOUND, while exhaustive characterization is a separate deliverable. Preserve the V3 strengths: whole-execution UB reasoning, exact supported-domain coverage, producer quantifiers, verdict certificates, reconstructed-proof reporting, module-local invariant discipline, and the conditional abstraction-design workflow. Do not add fixture names or hazard lists to the agent-facing skill. gherrit-pr-id: Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
joshlf
force-pushed
the
Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb
branch
from
September 3, 2026 04:42
36a2372 to
2613bd8
Compare
joshlf
enabled auto-merge
September 3, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the proof model around lossless representations and locally checkable
certificates, following the V3 gate failure and qualitative diagnosis.
Require an explicit case domain for each quantified claim and describe how
inputs map to obligation fibers. For equality, containment, disjointness, and
incomparability claims, require the exact direction-specific certificate and
the separating witnesses the relation demands. Treat feature, target,
allocator, toolchain, and policy expressions as semantic sets whose operators
must be justified before their denotations may be composed.
Model ordered and fallible construction as a staged relation rather than an
endpoint summary. Require transformations to retain enough information to
reverse or independently check the derivation, and reject prose such as by
inspection or all cases when the case mapping is not shown. Scope
counterexamples to the verdict actually requested: one complete existential
unsoundness witness closes UNSOUND, while exhaustive characterization is a
separate deliverable.
Preserve the V3 strengths: whole-execution UB reasoning, exact supported-domain
coverage, producer quantifiers, verdict certificates, reconstructed-proof
reporting, module-local invariant discipline, and the conditional
abstraction-design workflow. Do not add fixture names or hazard lists to the
agent-facing skill.
Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
This PR is on branch codex/unsafe-rust-stack.
Latest Update: v18 — Compare vs v17
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb && git checkout -b pr-Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb FETCH_HEADCheckout
git fetch origin refs/heads/Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gavvgvuiorzpz3yzrmmlq5zb5inu3nazb && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.